Skip to content

fix(tui): restore reliable mouse and responsive layout - #49

Open
t41372 wants to merge 1 commit into
rewrite/rust-ratatui-complete-20260808-codexfrom
fix/tui-mouse
Open

fix(tui): restore reliable mouse and responsive layout#49
t41372 wants to merge 1 commit into
rewrite/rust-ratatui-complete-20260808-codexfrom
fix/tui-mouse

Conversation

@t41372

@t41372 t41372 commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • require a semantic primary press and matching release, cancel stale owners, and route pointer input to the topmost visible overlay
  • make responsive root, body, footer, picker, modal, and management geometry usable at exact and zero-size boundaries
  • keep Unicode grapheme, tab, selection, and caret behavior correct while bounding multiline rendering to the visible viewport, including content beyond 65,535 rows
  • make terminal redraws selective and verify real SGR mouse input through a final-grid PTY oracle

Validation

  • cargo fmt --all --check
  • cargo clippy --locked --workspace --all-targets --all-features -- -D warnings
  • RUSTDOCFLAGS="-D warnings" cargo doc --locked --workspace --all-features --no-deps
  • fresh isolated workspace tests/examples plus every benchmark under aggregate LLVM coverage
  • bash scripts/check_coverage.sh /tmp/skit-tui-mouse-pr-final-v2.lcov — complete executable-source line coverage
  • survivor-driven mutation scans, exact current reruns, and line-level fault injection for the final overlay and viewport changes
  • cargo deny --locked check, cargo audit --deny warnings, Zizmor, and the documentation type/build/link checks

Scope

The UI model walker is intentionally not included here. PR #48 remains separate and untouched.

Make mouse activation semantic, topmost, and cancellation-safe across responsive TUI screens. Bound multiline rendering to the visible viewport and preserve Unicode caret behavior at large virtual offsets.
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e81c37ba-71bc-4c5e-8e2b-bab00e056d29

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.95448% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/skit-tui/src/terminal.rs 99.56% 2 Missing ⚠️
crates/skit-tui/src/pointer.rs 99.73% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@codspeed-hq

codspeed-hq Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 23 untouched benchmarks
⏩ 20 skipped benchmarks1


Comparing fix/tui-mouse (0edf38c) with rewrite/rust-ratatui-complete-20260808-codex (5af68f8)

Open in CodSpeed

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant